Skip to content

Guardrails / github

CODEOWNERS rules name teams ​

github/codeowners-team-owned@v1

Every rule in CODEOWNERS names at least one GitHub team, so ownership outlasts the people currently on it.

Idgithub/codeowners-team-owned
Versionv1
Categorygithub
Default severitywarning
Interpreterpython3
Timeout30 seconds
Violations tolerated0
Collectsgithub

Collectors ​

This guardrail doesn't gather anything itself. It relies on the collectors below, which the CLI runs once per build before any check, and reads what they found from GUARDRAIL_FACTS. If a collector collects nothing, this guardrail is skipped, not failed.

CollectorGathersInputs it is given
githubWhat GitHub itself reads out of the repository: the Actions workflows in .github/workflows, read as they are written, and the CODEOWNERS file, read as rules. For a workflow, which events start it, what token permissions it hands a job, which runner each job asks for, and every action a step reaches for and how tightly it is pinned. For CODEOWNERS, every pattern in file order with the owners it names, and the owners that apply to the paths a guardrail asks about, resolved the way GitHub resolves them, where the last rule to match a path is the one that owns it. Names and shapes only, never a secret, an input value or an environment value.workflows

The inputs above are this guardrail's own inputs, passed straight through to the collector. Setting one in buildnote.json changes what is collected, and two guardrails configured the same way share a single collection.

Configuration ​

json
{
  "guardrails": {
      "failOn": "error",
      "checks": [
          {
              "use": "github/codeowners-team-owned@v1",
              "severity": "warning",
              "with": {
                  "workflows": ".github/workflows/*.yml,.github/workflows/*.yaml",
                  "allowIndividuals": "true"
              },
              "exemptions": []
          }
      ]
  }
}

Inputs ​

InputDescriptionDefaultEnvironment variable
workflowsComma separated globs naming the workflows to read..github/workflows/*.yml,.github/workflows/*.yamlGUARDRAIL_INPUT_WORKFLOWS
allowIndividualsWhether a rule naming individuals alongside a team is accepted. A team is required either way; this only decides whether the individuals next to it are reported as a separate finding.trueGUARDRAIL_INPUT_ALLOWINDIVIDUALS

How to fix ​

Replace the individuals listed in the violations with the team they belong to:

-/api/   @dana @sam
+/api/   @company/backend

A rule naming individuals goes stale as soon as one of them changes team, and nothing warns you: GitHub keeps requesting reviews from someone who no longer works on that code. An @org/team owner moves membership out of this file, where changes are reviewed, and into the GitHub team, where membership is administered.

More in github ​

  • github/actions-pinned-by-digest. Every third-party action a workflow uses is pinned to a full commit sha, not to a tag or a branch.
  • github/codeowners-catch-all. CODEOWNERS has a rule matching every path, so even a file nobody thought about has an owner.
  • github/codeowners-no-unowned-rules. No rule in CODEOWNERS has an empty list of owners, which would remove ownership from everything it matches.
  • github/codeowners-owners-per-rule. Every rule in CODEOWNERS names at least the minimum and at most the maximum number of owners, so review neither depends on one person nor becomes everybody's problem.
  • github/codeowners-parses. Every line of CODEOWNERS that is not a comment is a rule GitHub can read, so no ownership is silently lost to a line GitHub ignores.
  • github/codeowners-present. The repository has a CODEOWNERS file where GitHub looks for one, with at least one rule, so every change has someone to review it.
  • github/job-timeout-set. Every job declares how long it may run, so a hung job is stopped instead of holding a runner until GitHub's own limit.
  • github/least-privilege-token. Every workflow declares permissions, and none of them grants write access to everything.

All 11 github guardrails

Buildnote Limited
Registered in England and Wales, Reg: 16140412