Skip to content

Guardrails / gitlab

No CODEOWNERS rule is left without an owner ​

gitlab/codeowners-no-unowned-rules@v1

No rule in CODEOWNERS ends up with no owners, counting the default owners it inherits from its section header, so no section claims a path without naming someone for it.

Idgitlab/codeowners-no-unowned-rules
Versionv1
Categorygitlab
Default severityerror
Interpreterpython3
Timeout30 seconds
Violations tolerated0
Collectsgitlab

Collectors ​

This guardrail doesn't gather anything itself. It relies on the collectors below, which the CLI runs once per build before any check, and reads what they found from GUARDRAIL_FACTS. If a collector collects nothing, this guardrail is skipped, not failed.

CollectorGathersInputs it is given
gitlabWhat GitLab itself reads out of the repository: the .gitlab-ci.yml, read as GitLab writes it, and the CODEOWNERS file, read as sections of rules. For the pipeline, the stages it declares, what it includes, and for every job the stage it sits in, the image and runner tags it asks for, how long it may run, the rules that decide whether it runs at all, and each script section with the variables it interpolates. For CODEOWNERS, every section with whether it is optional and how many approvals it needs, the rules under each, and the owners that apply to the paths a guardrail asks about, resolved per section the way GitLab resolves them. Names and shapes only, never a secret, a variable value or an environment value.pipelines

The inputs above are this guardrail's own inputs, passed straight through to the collector. Setting one in buildnote.json changes what is collected, and two guardrails configured the same way share a single collection.

Configuration ​

json
{
  "guardrails": {
      "failOn": "error",
      "checks": [
          {
              "use": "gitlab/codeowners-no-unowned-rules@v1",
              "severity": "error",
              "with": {
                  "pipelines": ".gitlab-ci.yml,.gitlab-ci.yaml"
              },
              "exemptions": []
          }
      ]
  }
}

Inputs ​

InputDescriptionDefaultEnvironment variable
pipelinesComma separated globs naming the GitLab CI files to read..gitlab-ci.yml,.gitlab-ci.yamlGUARDRAIL_INPUT_PIPELINES

How to fix ​

Give the rules named in the violations an owner, move them under a section that declares default owners, or delete them:

[Backend][2] @company/backend
/api/
/vendor/ @company/platform

A rule under a section with default owners doesn't need owners of its own, because it inherits the header's. A rule with neither is the problem: it matches paths in its section but owns none of them, so those paths look covered while GitLab asks nobody for approval. Because ownership resolves per section and the last matching rule wins within it, such a rule also overrides any broader rule above it in the same section.

More in gitlab ​

  • gitlab/codeowners-catch-all. A section that requires approval declares a rule matching every path, so a file nobody thought about still has an owner who must approve it.
  • gitlab/codeowners-owners-per-rule. Every rule in CODEOWNERS ends up with between the minimum and maximum number of owners, counting the default owners it inherits from its section header, so review depends neither on a single person nor on everyone.
  • gitlab/codeowners-parses. Every line of CODEOWNERS that isn't a comment is either a section header or a rule, so no ownership is silently lost to a line GitLab ignores.
  • gitlab/codeowners-present. The project has a CODEOWNERS file in one of the three places GitLab reads it from, and at least one section of it declares a rule, so every change has someone to review it.
  • gitlab/codeowners-team-owned. Every rule in CODEOWNERS ends up owned by at least one GitLab group, so ownership survives changes in who is on the team.
  • gitlab/job-timeout-set. Every job declares how long it may run, so a hung job is cut off rather than holding a runner until the project's own limit.

All 7 gitlab guardrails

Buildnote Limited
Registered in England and Wales, Reg: 16140412