Guardrails / gitlab

CODEOWNERS rules name groups

gitlab/codeowners-team-owned@v1

Every rule in CODEOWNERS ends up owned by at least one GitLab group, so ownership survives changes in who is on the team.

Id	gitlab/codeowners-team-owned
Version	v1
Category	gitlab
Default severity	warning
Interpreter	python3
Timeout	30 seconds
Violations tolerated	0
Collects	gitlab

Collectors

This guardrail doesn't gather anything itself. It relies on the collectors below, which the CLI runs once per build before any check, and reads what they found from GUARDRAIL_FACTS. If a collector collects nothing, this guardrail is skipped, not failed.

Collector	Gathers	Inputs it is given
gitlab	What GitLab itself reads out of the repository: the .gitlab-ci.yml, read as GitLab writes it, and the CODEOWNERS file, read as sections of rules. For the pipeline, the stages it declares, what it includes, and for every job the stage it sits in, the image and runner tags it asks for, how long it may run, the rules that decide whether it runs at all, and each script section with the variables it interpolates. For CODEOWNERS, every section with whether it is optional and how many approvals it needs, the rules under each, and the owners that apply to the paths a guardrail asks about, resolved per section the way GitLab resolves them. Names and shapes only, never a secret, a variable value or an environment value.	pipelines

The inputs above are this guardrail's own inputs, passed straight through to the collector. Setting one in buildnote.json changes what is collected, and two guardrails configured the same way share a single collection.

Configuration

{
  "guardrails": {
      "failOn": "error",
      "checks": [
          {
              "use": "gitlab/codeowners-team-owned@v1",
              "severity": "warning",
              "with": {
                  "pipelines": ".gitlab-ci.yml,.gitlab-ci.yaml",
                  "allowIndividuals": "true"
              },
              "exemptions": []
          }
      ]
  }
}

Inputs

Input	Description	Default	Environment variable
pipelines	Comma separated globs naming the GitLab CI files to read.	.gitlab-ci.yml,.gitlab-ci.yaml	GUARDRAIL_INPUT_PIPELINES
allowIndividuals	Whether a rule that ends up with individuals alongside a group is accepted. A group is required either way; this only decides whether the individuals next to it are reported as a finding of their own.	true	GUARDRAIL_INPUT_ALLOWINDIVIDUALS

How to fix

Replace the individuals named in the violations with their group, either on the rule or on the section header above it:

-/api/ @dana @sam
+/api/ @company/backend

A rule that names individuals goes stale as soon as one of them changes team, and nothing warns you: GitLab keeps asking for approval from someone who no longer works on that code. A group owner moves membership out of this file, where changes are reviewed, and into the group, where it is administered. A subgroup such as @company/security/appsec counts as a group.

More in gitlab

• gitlab/codeowners-catch-all. A section that requires approval declares a rule matching every path, so a file nobody thought about still has an owner who must approve it.
• gitlab/codeowners-no-unowned-rules. No rule in CODEOWNERS ends up with no owners, counting the default owners it inherits from its section header, so no section claims a path without naming someone for it.
• gitlab/codeowners-owners-per-rule. Every rule in CODEOWNERS ends up with between the minimum and maximum number of owners, counting the default owners it inherits from its section header, so review depends neither on a single person nor on everyone.
• gitlab/codeowners-parses. Every line of CODEOWNERS that isn't a comment is either a section header or a rule, so no ownership is silently lost to a line GitLab ignores.
• gitlab/codeowners-present. The project has a CODEOWNERS file in one of the three places GitLab reads it from, and at least one section of it declares a rule, so every change has someone to review it.
• gitlab/job-timeout-set. Every job declares how long it may run, so a hung job is cut off rather than holding a runner until the project's own limit.

All 7 gitlab guardrails