Skip to content
BETAGuardrails are in beta. The library, the configuration format and the CLI command can still change.

Guardrails / ownership

CODEOWNERS covers everything

ownership/catch-all-rule@v1

CODEOWNERS declares a rule matching every path, so a file nobody thought about still has an owner.

Idownership/catch-all-rule
Versionv1
Categoryownership
Default severitywarning
Interpreterpython3
Timeout30 seconds
Violations tolerated0
Collectscodeowners

Collectors

This guardrail gathers nothing itself. It depends on the collectors below, which the CLI runs once per build before any check, and reads what they found out of GUARDRAIL_FACTS. A collector that collects nothing skips this guardrail rather than failing it.

CollectorGathersInputs it is given
codeownersThe CODEOWNERS file the repository carries, read as rules rather than as text: every pattern in file order with the owners it names, how many rules each owner is named by, and the owners that apply to the paths a guardrail asks about, resolved the way GitHub resolves them, where the last rule to match a path is the one that owns it.none

The inputs above are this guardrail's own, passed straight through. Configuring one in buildnote.json changes what is collected, and two guardrails configured the same way share the one collection.

Configuration

json
{
  "guardrails": {
      "failOn": "error",
      "comment": true,
      "checks": [
          {
              "use": "ownership/catch-all-rule@v1",
              "severity": "warning",
              "with": {
                  "patterns": "*,**,/*"
              },
              "exemptions": []
          }
      ]
  }
}

Inputs

InputDescriptionDefaultEnvironment variable
patternsComma separated patterns, any one of which counts as matching every path.*,**,/*GUARDRAIL_INPUT_PATTERNS

How to fix

Add a catch-all as the first rule, then narrow it below:

*               @acme/platform
/terraform/     @acme/infrastructure

Ownership resolves last match wins, so a catch-all at the top is the floor rather than the override. Without one, a new directory nobody wrote a rule for is owned by nobody, and the gap is invisible until a change lands in it.

More in ownership

  • ownership/codeowners-parses. Every line of CODEOWNERS that is not a comment reads as a rule, so no ownership is silently lost to a line the forge ignores.
  • ownership/codeowners-present. The repository carries a CODEOWNERS file naming at least one rule, so every change has somebody to review it.
  • ownership/no-unowned-rules. No rule in CODEOWNERS names an empty set of owners, which would take ownership away from everything it matches.
  • ownership/owners-per-rule. Every rule in CODEOWNERS names at least the minimum owners and no more than the maximum, so review is neither one person's bus factor nor everybody's problem.
  • ownership/team-owned. Every rule in CODEOWNERS names at least one team, so ownership survives the people currently in it.

All 6 ownership guardrails

Buildnote Limited
Registered in England and Wales, Reg: 16140412