Guardrails / ownership

No CODEOWNERS rule removes ownership

ownership/no-unowned-rules@v1

No rule in CODEOWNERS names an empty set of owners, which would take ownership away from everything it matches.

Id	ownership/no-unowned-rules
Version	v1
Category	ownership
Default severity	error
Interpreter	python3
Timeout	30 seconds
Violations tolerated	0
Collects	codeowners

Collectors

This guardrail gathers nothing itself. It depends on the collectors below, which the CLI runs once per build before any check, and reads what they found out of GUARDRAIL_FACTS. A collector that collects nothing skips this guardrail rather than failing it.

Collector	Gathers	Inputs it is given
codeowners	The CODEOWNERS file the repository carries, read as rules rather than as text: every pattern in file order with the owners it names, how many rules each owner is named by, and the owners that apply to the paths a guardrail asks about, resolved the way GitHub resolves them, where the last rule to match a path is the one that owns it.	none

The inputs above are this guardrail's own, passed straight through. Configuring one in buildnote.json changes what is collected, and two guardrails configured the same way share the one collection.

Configuration

{
  "guardrails": {
      "failOn": "error",
      "comment": true,
      "checks": [
          {
              "use": "ownership/no-unowned-rules@v1",
              "severity": "error",
              "with": {},
              "exemptions": []
          }
      ]
  }
}

How to fix

Give the rules named in the violations an owner, or delete them:

/vendor/   @acme/platform

A pattern with no owners after it is valid and deliberate: it removes ownership from every path it matches, and because resolution is last match wins it overrides the catch-all above it. That is almost never what the line was meant to say, and the result is a directory that reads as owned until somebody opens a pull request against it.

More in ownership

• ownership/catch-all-rule. CODEOWNERS declares a rule matching every path, so a file nobody thought about still has an owner.
• ownership/codeowners-parses. Every line of CODEOWNERS that is not a comment reads as a rule, so no ownership is silently lost to a line the forge ignores.
• ownership/codeowners-present. The repository carries a CODEOWNERS file naming at least one rule, so every change has somebody to review it.
• ownership/owners-per-rule. Every rule in CODEOWNERS names at least the minimum owners and no more than the maximum, so review is neither one person's bus factor nor everybody's problem.
• ownership/team-owned. Every rule in CODEOWNERS names at least one team, so ownership survives the people currently in it.

All 6 ownership guardrails